Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support deploying v1alpha2 and v1alpha1 controllers simultaneously #598

Closed
jlewi opened this issue May 21, 2018 · 4 comments
Closed

Support deploying v1alpha2 and v1alpha1 controllers simultaneously #598

jlewi opened this issue May 21, 2018 · 4 comments

Comments

@jlewi
Copy link
Contributor

jlewi commented May 21, 2018

To support development of v1alpha2 and migration to the v1alpha2 API, we'd like to make it possible to deploy controllers for v1alpha1 and v1alpha2 in the same cluster.

The controllers should only claim/operate on API objects with the correct version.

@jlewi
Copy link
Contributor Author

jlewi commented May 21, 2018

It looks like informers are scoped to specific versions.

https://github.com/kubeflow/tf-operator/blob/master/pkg/controller/controller.go#L110
https://github.com/kubeflow/tf-operator/blob/master/pkg/controller.v2/controller.go#L205

So I think the different controllers are already scoped to specific versions. And no additional work is needed.

I will open up a separate issue to add an appropriate ksonnet package.

@jlewi
Copy link
Contributor Author

jlewi commented May 22, 2018

It looks like K8s doesn't support deploying multiple versions of the resource simultaneously;
see kubernetes/enhancements#544

One workaround is to create a resource with a different name.

@gaocegege
Copy link
Member

Yeah, I meet the same problem.

@gaocegege
Copy link
Member

I am closing the issue since we know it is not supported by kubernetes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants