From 582592ab5a96a531d3f91d8931ead93da9b51551 Mon Sep 17 00:00:00 2001 From: Ashray Jain Date: Thu, 8 Feb 2024 17:04:03 -0800 Subject: [PATCH 1/2] Fix check for gid being less than 0 We were checking the uid instead of the gid when we check the configured value against 0 --- pkg/driver/controller.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/driver/controller.go b/pkg/driver/controller.go index 031738208..e0d2dea77 100644 --- a/pkg/driver/controller.go +++ b/pkg/driver/controller.go @@ -183,7 +183,7 @@ func (d *Driver) CreateVolume(ctx context.Context, req *csi.CreateVolumeRequest) if err != nil { return nil, status.Errorf(codes.InvalidArgument, "Failed to parse invalid %v: %v", Gid, err) } - if uid < 0 { + if gid < 0 { return nil, status.Errorf(codes.InvalidArgument, "%v must be greater or equal than 0", Gid) } } From e46af3fedeb8b71067ee92be2c56418fe9320e62 Mon Sep 17 00:00:00 2001 From: Ryan Stankiewicz Date: Thu, 15 Feb 2024 19:15:32 +0000 Subject: [PATCH 2/2] Disable efs-utils version check A "version check" feature was introduced into v1.35.1 of efs-utils. This check runs once an hour and may result in the watchdog process making API calls to Github. This commit disables this feature. --- pkg/driver/efs_watch_dog.go | 2 ++ pkg/driver/efs_watch_dog_test.go | 2 ++ 2 files changed, 4 insertions(+) diff --git a/pkg/driver/efs_watch_dog.go b/pkg/driver/efs_watch_dog.go index 8c5f719ad..0035279fd 100644 --- a/pkg/driver/efs_watch_dog.go +++ b/pkg/driver/efs_watch_dog.go @@ -108,6 +108,8 @@ stunnel_health_check_enabled = true stunnel_health_check_interval_min = 5 stunnel_health_check_command_timeout_sec = 30 +enable_version_check = false + [client-info] source={{.EfsClientSource}} diff --git a/pkg/driver/efs_watch_dog_test.go b/pkg/driver/efs_watch_dog_test.go index e77a1cc14..25f7a2130 100644 --- a/pkg/driver/efs_watch_dog_test.go +++ b/pkg/driver/efs_watch_dog_test.go @@ -98,6 +98,8 @@ stunnel_health_check_enabled = true stunnel_health_check_interval_min = 5 stunnel_health_check_command_timeout_sec = 30 +enable_version_check = false + [client-info] source=k8s