Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support additional EKS config options #2853

Closed
richardcase opened this issue Oct 15, 2021 · 3 comments · Fixed by #2965
Closed

Support additional EKS config options #2853

richardcase opened this issue Oct 15, 2021 · 3 comments · Fixed by #2965
Assignees
@richardcase
Labels
area/provider/eks Issues or PRs related to Amazon EKS provider kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@richardcase
Copy link
Member

/kind feature
/area provider/eks

Describe the solution you'd like
At present we only expose the --kubelet-extra-args argument to EKS bootstrap.sh via the EKSConfig. We should expose the additional bootstrap options.

Anything else you would like to add:
As an example someone may want to specify the container runtime to use via the ----container-runtime option.

Environment:

  • Cluster-api-provider-aws version: 1.0.0
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/provider/eks Issues or PRs related to Amazon EKS provider needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 15, 2021
@richardcase
Copy link
Member Author

/assign
/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Oct 15, 2021
@richardcase
Copy link
Member Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 15, 2021
@richardcase richardcase added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Oct 15, 2021
@richardcase richardcase mentioned this issue Oct 15, 2021
Closed
4 tasks
@richardcase richardcase mentioned this issue Nov 16, 2021
Merged
2 tasks
@richardcase
Copy link
Member Author

/milestone v1.2.0

@k8s-ci-robot k8s-ci-robot added this to the v1.2.0 milestone Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richardcase richardcase

Labels
area/provider/eks Issues or PRs related to Amazon EKS provider kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: expose additional eks bootstrap options
WIP feat: expose additional EKS bootstrap options
2 participants
@richardcase @k8s-ci-robot