Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KCP upgrades with imageRepository changed aren't complete #2805

Closed
yastij opened this issue Mar 27, 2020 · 2 comments · Fixed by #2807
Closed

KCP upgrades with imageRepository changed aren't complete #2805

yastij opened this issue Mar 27, 2020 · 2 comments · Fixed by #2807
Assignees
@benmoss
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v0.3.3

Comments

@yastij
Copy link
Member

yastij commented Mar 27, 2020

What steps did you take and what happened:

when performing a KCP upgrade from v1.17.1 to v1.17.3 and updating KCP's imageRepository in the clusterConfiguration, dns and etcd the KCP is edited successfully. but when reconciling the upgrade kubeadm is trying to pull the core k8s components from the old imageRepository (coreDNS and kube-proxy didn't get updated too).

when checking the kubeadm configmap the imageRepository for etcd is the only one updated, the other ones are still pointing to the old registry.

cc @ncdc @vincepri @randomvariable @benmoss

What did you expect to happen:

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Cluster-api version:
  • Minikube/KIND version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):

/kind bug
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 27, 2020
@yastij
Copy link
Member Author

yastij commented Mar 27, 2020

/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Mar 27, 2020
@vincepri
Copy link
Member

/milestone v0.3.3
/priority critical-urgent
/assign @benmoss
/lifecycle active

@k8s-ci-robot k8s-ci-robot added lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Mar 27, 2020
@k8s-ci-robot k8s-ci-robot added this to the v0.3.3 milestone Mar 27, 2020
@benmoss benmoss mentioned this issue Mar 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benmoss benmoss

Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v0.3.3
Development

Successfully merging a pull request may close this issue.

🐛 KCP should update Kubeadm config map when setting imageRepository benmoss/cluster-api
4 participants
@benmoss @vincepri @yastij @k8s-ci-robot