From 1230d607aca6f708b0f09b59ae180fdf066fc45f Mon Sep 17 00:00:00 2001 From: Rouke Broersma Date: Thu, 18 Jul 2024 14:31:49 +0200 Subject: [PATCH] Helm: Add revision history limit for worker daemonset (#1797) * Helm: Add revision history limit for worker daemonset Signed-off-by: Rouke Broersma * Helm: Add revision history limit for topology updater daemonset Signed-off-by: Rouke Broersma * chore: tidy table columns --------- Signed-off-by: Rouke Broersma --- .../node-feature-discovery/templates/topologyupdater.yaml | 1 + .../helm/node-feature-discovery/templates/worker.yaml | 1 + deployment/helm/node-feature-discovery/values.yaml | 7 +++++++ docs/deployment/helm.md | 2 ++ 4 files changed, 11 insertions(+) diff --git a/deployment/helm/node-feature-discovery/templates/topologyupdater.yaml b/deployment/helm/node-feature-discovery/templates/topologyupdater.yaml index 1fc32bbdb1..8991f5fbf6 100644 --- a/deployment/helm/node-feature-discovery/templates/topologyupdater.yaml +++ b/deployment/helm/node-feature-discovery/templates/topologyupdater.yaml @@ -12,6 +12,7 @@ metadata: {{- toYaml . | nindent 4 }} {{- end }} spec: + revisionHistoryLimit: {{ .Values.topologyUpdater.revisionHistoryLimit }} selector: matchLabels: {{- include "node-feature-discovery.selectorLabels" . | nindent 6 }} diff --git a/deployment/helm/node-feature-discovery/templates/worker.yaml b/deployment/helm/node-feature-discovery/templates/worker.yaml index 684681324b..48512eed9c 100644 --- a/deployment/helm/node-feature-discovery/templates/worker.yaml +++ b/deployment/helm/node-feature-discovery/templates/worker.yaml @@ -12,6 +12,7 @@ metadata: {{- toYaml . | nindent 4 }} {{- end }} spec: + revisionHistoryLimit: {{ .Values.worker.revisionHistoryLimit }} selector: matchLabels: {{- include "node-feature-discovery.selectorLabels" . | nindent 6 }} diff --git a/deployment/helm/node-feature-discovery/values.yaml b/deployment/helm/node-feature-discovery/values.yaml index cbf8b1db58..6a40df698e 100644 --- a/deployment/helm/node-feature-discovery/values.yaml +++ b/deployment/helm/node-feature-discovery/values.yaml @@ -425,6 +425,9 @@ worker: # If not set and create is true, a name is generated using the fullname template name: + # specify how many old ControllerRevisions for the DaemonSet to retain. + revisionHistoryLimit: + rbac: create: true @@ -468,6 +471,10 @@ topologyUpdater: create: true annotations: {} name: + + # specify how many old ControllerRevisions for the DaemonSet to retain. + revisionHistoryLimit: + rbac: create: true diff --git a/docs/deployment/helm.md b/docs/deployment/helm.md index 7e73a93795..decacda5b3 100644 --- a/docs/deployment/helm.md +++ b/docs/deployment/helm.md @@ -168,6 +168,7 @@ API's you need to install the prometheus operator in your cluster. | `worker.annotations` | dict | {} | NFD worker pod [annotations](https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/) | | `worker.daemonsetAnnotations` | dict | {} | NFD worker daemonset [annotations](https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/) | | `worker.args` | array | [] | Additional [command line arguments](../reference/worker-commandline-reference.md) to pass to nfd-worker | +| `worker.revisionHistoryLimit` | integer | | Specify how many old ControllerRevisions for this DaemonSet you want to retain. [revisionHistoryLimit](https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/daemon-set-v1/#DaemonSetSpec) | ### Topology updater parameters @@ -198,6 +199,7 @@ API's you need to install the prometheus operator in your cluster. | `topologyUpdater.podSetFingerprint` | bool | true | Enables compute and report of pod fingerprint in NRT objects. | | `topologyUpdater.kubeletStateDir` | string | /var/lib/kubelet | Specifies kubelet state directory path for watching state and checkpoint files. Empty value disables kubelet state tracking. | | `topologyUpdater.args` | array | [] | Additional [command line arguments](../reference/topology-updater-commandline-reference.md) to pass to nfd-topology-updater | +| `topologyUpdater.revisionHistoryLimit` | integer | | Specify how many old ControllerRevisions for this DaemonSet you want to retain. [revisionHistoryLimit](https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/daemon-set-v1/#DaemonSetSpec) | ### Garbage collector parameters