Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovery of PMEM / NVDIMM devices #178

Closed
kad opened this issue Oct 10, 2018 · 3 comments
Closed

Discovery of PMEM / NVDIMM devices #178

kad opened this issue Oct 10, 2018 · 3 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@kad
Copy link
Contributor

kad commented Oct 10, 2018

It would be good if NFD will be able to detect and report presence of PMEM devices on the node.

Minimal way to detect that can be presence of entries under /sys/class/nd/ hierarchy.

Label can be something like nfd-pmem.present

@marquiz
Copy link
Contributor

marquiz commented Oct 10, 2018

I was thinking about the feature source. Would it be more logical to have a separate source (like pmem that you suggested), with a label like nfd-pmem-present, or, put it under currently existing feature source such as memory or storage, having label like nfd-storage-pmem.present?

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 26, 2019
@marquiz
Copy link
Contributor

marquiz commented Apr 26, 2019

Detection of nvdimm hardware was merged in #214. Closing this issue

@marquiz marquiz closed this as completed Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants