Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop run-time dynamic configuration updates #1846

Closed
marquiz opened this issue Aug 19, 2024 · 0 comments · Fixed by #1847
Closed

Drop run-time dynamic configuration updates #1846

marquiz opened this issue Aug 19, 2024 · 0 comments · Fixed by #1847
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@marquiz
Copy link
Contributor

marquiz commented Aug 19, 2024

What would you like to be added:

I suggest to drop the fsnotify based run-time reconfiguration of nfd-worker and nfd-master. All deployment methods (kustomize, Helm, operator) support (hash-based) pod restarts on configmap changes so we should use that. There have been issues reported on the current behavior (e.g. #805) where in some scenarios kubelet touches the mounted configmap every minute, causing a reconfiguration to happen every-minute. This behavior can be particularly detrimental on big clusters (of thousands of nodes) as reconfiguration of the nfd-master effectively restarts the object informers, causing it to resync object caches, putting heavy load on the apiserver/etcd.

Why is this needed:

  1. Simplifies the code and reduces possible error (corner) scenarios
  2. Simplifies the usage as there are never going to be config file settings that cannot be dynamically updated
  3. Consistent functionality accross nfd-master, nfd-worker and nfd-topology-updater (topology-updater doesn't support dynamic runt-time reconfiguration)
@marquiz marquiz added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant