Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to glide from godeps #65

Closed
dlorenc opened this issue May 12, 2016 · 6 comments
Closed

Switch to glide from godeps #65

dlorenc opened this issue May 12, 2016 · 6 comments
Labels
area/code-deps Code dependencies (guest-vm deps belong in guest-vm)

Comments

@dlorenc
Copy link
Contributor

dlorenc commented May 12, 2016

See #33.

Glide gives more control in pinning the versions of dependencies, like k8s.io/kubernetes. It might make it easier to update to newer versions of k8s than godep currently does.

cc @ethernetdan @vishh @luxas
Thoughts?

@vishh
Copy link
Contributor

vishh commented May 12, 2016

Glide still has a couple of issues that might be of concern -

Masterminds/glide#367
Masterminds/glide#368
Masterminds/glide#319

@vishh
Copy link
Contributor

vishh commented May 12, 2016

I'd recommend holding on to godep, until the issues mentioned above are fixed in glide. Switching to the vendor directory is itself a good first step.

@dlorenc
Copy link
Contributor Author

dlorenc commented May 13, 2016

I guess it's a case of the lesser of two evils... I just spent a few hours trying to update the kubernetes components we use, and I got stuck on kubernetes/kubernetes#23529

:(

@luxas
Copy link
Member

luxas commented May 13, 2016

@dlorenc Which godep version are you using?

Switching to the vendor directory is itself a good first step.

@vishh Don't know if you noticed, but we've used vendor/ from the beginning :)

@dlorenc
Copy link
Contributor Author

dlorenc commented May 13, 2016

I've tried HEAD, 53 and 63 I think. They've all failed in different, mysterious ways. One of them left .git repos all over my vendor directory which basically broke everything.

I almost have stuff building with glide and k8s at head though. I'm chasing down a few int<->int32 swaps that I think @luxas was responsible for :)

I'll try to push it tomorrow to show what it looks like.

@luxas luxas added area/code-deps Code dependencies (guest-vm deps belong in guest-vm) area/test-infra labels May 19, 2016
@dlorenc
Copy link
Contributor Author

dlorenc commented Jun 7, 2016

Closing this for now, we can revisit if/when k8s makes the switch.

@dlorenc dlorenc closed this as completed Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/code-deps Code dependencies (guest-vm deps belong in guest-vm)
Projects
None yet
Development

No branches or pull requests

3 participants