-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request] Skip destroy if no resource is actually created #346
Comments
Try two wrong applications below. apiVersion: core.oam.dev/v1beta1
kind: Application
metadata:
name: wrong-rds-db
spec:
components:
- name: wrong-rds-db
type: alibaba-rds-database
properties:
region: cn-hangzhou
existing_instance_id: FAKE_ID
database_name: first_database
password: U34rfwefwefffaked
account_name: first_db_account When |
After v0.7.10, Configuration can be deleted before it is fully created. PR #354 has supportted
|
Feature Request
Now we will dispatch destroy job if Configuration is deleted. However, sometimes no resources is created due to the wrong Configuration. In this case, we should detect the resource creation phase and skip the destroy phase depends on the situation.
1. What kubevela/kubevela#3929 do
In deletion part, kubevela#3929 will set
configuration.spec.forceDelete
to true. Anything else is dealt with terraform-controller.Origin Post
Hey, I know this is merged, but I realized when you have something wrong the deletion don't complete. For example, Imagine you go to the Cloud provider portal and delete the resource, terraform will fail to delete saying the resource doesn't exist, like this:
The same happen if I accidentally make a mistake in a HCL and apply some components in an application, but try to delete after realize I did a mistake, the delete never happen.
I just did it on my test environment and can't delete the application even using
force
.I receive a:
Originally posted by @alisson276 in kubevela/kubevela#3929 (comment)
The text was updated successfully, but these errors were encountered: