Validate import namespace specified functions properly

[kungfooman]

This error is caused by:

RuntimeTypeInspector.js/src-runtime/inspectType.js

Lines 21 to 34 in 3ec2e10

	if (typeof expect === 'string' && expect.includes('.')) {
	// E.g. ['MathUtils', 'Quaternion']
	const parts = expect.split('.');
	if (parts.length === 2) {
	const [a, b] = parts;
	if (importNamespaceSpecifiers[a]) {
	const expectWhat = typeof importNamespaceSpecifiers[a][b];
	// console.log("expectWhat", expectWhat);
	expect = expectWhat;
	}
	} else {
	console.log("import namespace specifier rewrite unhandled", {expect, parts});
	}
	}

Clearly the instance of a class isn't a function - otherwise the logic works for other primitive types like numbers.

So I need some special casing for the case of importNamespaceSpecifiers[a][b].constructor

We may be tempted to use importNamespaceSpecifiers[a][b].name, but I don't think this goes far enough - after all you can make nameless classes/functions:

function a() {
    return () => {}
}
f = a()

Or in more familiar terms:

function makeVec3Class() {
    return function() {
        this.x = 1;
        this.y = 2;
        this.z = 3;
    }
}
const Vec3 = makeVec3Class();
vec = new Vec3

Output:

It seems that TypeScript is itself confused:

/**
 * @param {B.Vec3} vec - The vector.
 */
function testVec(vec) {
  console.log("testVec got", {vec});
}
testVec(new B.Vec3());

Error:

Argument of type '(Anonymous function)' is not assignable to parameter of type 'typeof (Anonymous function)'.
  Type '(Anonymous function)' provides no match for the signature '(): void'.ts(2345)
(alias) new Vec3(): (Anonymous function)
export Vec3

Right now I'm tempted to imply that any import namespace specifier function assumes an object with given function as prototype:

if (value.constructor === importNamespaceSpecifiers[a][b]) {
  return true;
}