Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Junk files in the release tar.gz file #39

Open
infamy opened this issue Feb 5, 2023 · 5 comments
Open

Junk files in the release tar.gz file #39

infamy opened this issue Feb 5, 2023 · 5 comments

Comments

@infamy
Copy link

infamy commented Feb 5, 2023

You have a ton of ._ files in the release tar.gz. These are cache files. I would recommend moving the release process to something like github workflows/ci/cd to prevent this. (same thing is present in guimods)

@kwindrem
Copy link
Owner

kwindrem commented Feb 5, 2023

This was true at one time but I just checked the current release for SetupHelper and GuiMods and see no ._ files. The only thing I found was one .DS_Store file which I'll remove on the next release.

I also checked the blind install archive and found nothing there.

If you have a specific example, please let me know and I'll work on removing them.

@infamy
Copy link
Author

infamy commented Feb 6, 2023

Iin the readme you link to

venus-data.tgz is available here:
    https://github.com/kwindrem/SetupHelper/raw/main/venus-data.tgz

Inside that file, i see a ._rc and then each directory is littered full of ._folderorfilenamehere

@kwindrem
Copy link
Owner

kwindrem commented Feb 6, 2023

Got it. Didn't realize you were talking about the blind install which is different than what gets into the repo.

I have a fix and will include it in the next release. Unless you disagree, I don't consider this a serious issue requiring a new version just for this.

@infamy
Copy link
Author

infamy commented Feb 6, 2023

Yeah, I don't think it causes any issues. Just extra files. if there a reason you don't build the blind release with github actions? (would just be an extra assset)

@kwindrem
Copy link
Owner

kwindrem commented Feb 6, 2023

I don't know that much about GitHub. It might be possible although I go outside the root file for SetupHelper to generate the necessary code since rcS.local and the rc directory needs to end up in /data not inside /data/SetupHelper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants