-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add google upload script to package managers #85
Comments
@labbots You mean add a package in homebrew database ? so we can install it by homebrew command ? We might as well add to other package managers. |
Yes @Akianonymus you are right |
This is a good idea. I am currently working on making the script posix compatible, it's almost complete. Although, wanted some suggestions. Should i keep the bash version of the script along with posix, making it two scripts, and thus two to maintain, won't be difficult enough as most changes are similar, or just one posix script. install script will be one, posix compatible and will install bash version if bash present, otherwise posix version. |
I am concerned about the performance on posix script to bash script. I don't like the idea of maintaining 2 set of scripts but i don't want to loose the advantage bash has. So for now i think it would be wise to maintain bash script. It would be great if we could have a performance test between the two versions of the script. |
@labbots Well, rationally speaking, there won't be much of a performance penalty in real time, as it all comes to external network requests. and for the same reason, kinda difficult to benchmark the script. Extra programs that will become necessary is awk and ps. Also one more program to get the column size, bash or zsh or stty or tput, whatever available will be used, otherwise simple logging. Several function like _count, using regex inside test ( [[ ) will be also lost, and have use case, if possible, otherwise grep. Again, these may seem like a huge stack of changes, but in real life, won't affect anyone, assuming no one is running this script on an machine with very limited process forking and extremely slow processing power. But we won't have to worry about all above things if we just maintain two sets of scripts. |
@labbots i was excepting a reply whether i should keep both or not |
Let's have both the version of the script please |
First thing first, which package managers will even allow this script ? Package managers don't usually add unless and until the project is quite famous and relevant, but not necessarily. Homebrew seems possible, apt is less to zero chance, dunno about others. If anyone would like to throw some info, please do so. |
Now, to achieve this, have to seperate self update code from main script, and also the uninstall script. Next thing would be to create a man page file, containing all documentation. If install.sh will be used then, self update and uninstall will be possiblle, otherwise no. |
@Akianonymus I am more inclined towards adding it to brew. |
Identify whether the google drive upload script could be added as homebrew formula. If it is feasible then make necessary changes to add gupload script to mac and linux homebrew formula.
This makes it easy for users to setup and use the script.
The text was updated successfully, but these errors were encountered: