Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit Word Count for discussions (and answers) #135

Open
NinaHerrmann opened this issue May 17, 2023 · 4 comments
Open

Limit Word Count for discussions (and answers) #135

NinaHerrmann opened this issue May 17, 2023 · 4 comments

Comments

@NinaHerrmann
Copy link
Contributor

NinaHerrmann commented May 17, 2023

Currently post are of type text and can therefore be 1 GB long (which I guess is an issue in itself, so a default value makes sense.... Anyway ... )
(Split from #91)

Limiting the number of characters is the easiest implementation which I hope also does the job (@pejhab).

Implementation

  • additional setting Maximum Characters (default setting?)
  • additional setting Minimum Characters
    (- optional field discussions and answers?)
  • additional db-field in moodleoverflow_discussion maxchars
  • pass value optionally to editor (I think it is maxbytes...)
  • unit Test - create post with maxbytes/minbytes

As pjhab said, minimum characters prevent "LOL" Post - Not a lot of meaning and impeding to read a discussion, and maxbytes prevent "rants"

@pejhab
Copy link

pejhab commented May 17, 2023

Great to see you are working on this!

May I add that ideally we should be able to set a minimum as well as maximum number of words?

A minimum to fire-proof the discussions against what I call LOL posts and a maximum to guard against "rants". ;-)

@NinaHerrmann
Copy link
Contributor Author

Thanks for reading over it - sounds like a very good idea! (Although I like "rants" ;) )
I will edit the description!

@NinaHerrmann
Copy link
Contributor Author

Just one other thought - To circumvent that limit user might just create multiple post, so it make make sense to have some additional maximum post per discussion limit which kind of related to #134.

@pejhab
Copy link

pejhab commented May 19, 2023

I agree. It does make sense.

(But even if it didn't, I would still say we should add the option if it's within our powers. ;-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants