Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypassing anonymous mode #171

Closed
gergelyrakoczi opened this issue Jan 10, 2024 · 5 comments · Fixed by #173
Closed

Bypassing anonymous mode #171

gergelyrakoczi opened this issue Jan 10, 2024 · 5 comments · Fixed by #173

Comments

@gergelyrakoczi
Copy link

Thank you for this great plugin, we love it at TU Wien - especially the anonymous mode. In this mode I have detected an interesting thing.
When a teacher sets the parameter "Anonymous" to "Questioners and answerers (irreversible!)" and later edits a posting of a student that includes an attachment, in the details of the attachment the teacher can identify the name of the author. This bypasses anonymity.

See in this screenshot:
moodleoverflow_screenshot_2024

Did I misconfigure something or is this an open issue/bug somehow.

Looking forward to hearing from you.

Thank you and keep up the great work.

Best regards,
Gergely Rakoczi

@NinaHerrmann
Copy link
Contributor

Hey Gergely Rakoczi,
indeed this is a bug that I did not encounter beforehand. As the filepicker is taken from core Moodle we have to do some research on files that can be uploaded anonymously. Otherwise, I think the only valid behavior is to disallow file uploading for anonymous forums or disable editing 🤔
Thanks for reporting we will take a look at it cheers,
Nina

@gergelyrakoczi
Copy link
Author

Hi Nina,
you are welcome and thank you for having a look at it. I agree - preventing attachments will work, however from a didactical point of view they are really useful in some cases.
Thank you and best regards from Vienna,
Gergely

@NinaHerrmann
Copy link
Contributor

#173 might be a solution - however, the pull request requires tests before being merged. If you have time it would help us greatly if you would test the branch!

@gergelyrakoczi
Copy link
Author

Superb, thank you. I have tested it locally and now instead of the user's name, I see "Anonym" (as a teacher). Great thank you!

@NinaHerrmann
Copy link
Contributor

Okay, that is great! I think we still need to test minor things e.g. what happens if files are changed removed etc. but looks like we have a solution where we do no have to limit functionality! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants