Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems following upgrade #190

Closed
pejhab opened this issue Jul 15, 2024 · 10 comments
Closed

Problems following upgrade #190

pejhab opened this issue Jul 15, 2024 · 10 comments
Assignees
Labels

Comments

@pejhab
Copy link

pejhab commented Jul 15, 2024

Hello,

I have recently upgraded to Moodleoverflow v4.4-r1 and now video filters have stopped working (Generico and generic Moodle video embed). I am further looking into this.

Have you had similar reports?

Regards,

P.H.

@pejhab
Copy link
Author

pejhab commented Jul 15, 2024

To clarify, the Generico filter works fine if I use it to embed a video in a post on a Moodle standard forum, but it fails on Moodle overflow.

STARNDARD FORUM:

image

OVERFLOW:

image

My Moodle version: 4.1+ (Build: 20221209)

@pejhab
Copy link
Author

pejhab commented Jul 15, 2024

I have also noticed that glossary linking no longer works on Moodleoverflow.

@NinaHerrmann
Copy link
Contributor

@TamaroWalter Could you please test that?

@pejhab
Copy link
Author

pejhab commented Jul 15, 2024

Glossary "auto-linking", that is.

@pejhab
Copy link
Author

pejhab commented Jul 17, 2024

Could you please confirm this as a bug? All our videos on all our Moodleoverflow forums have stopped working.

@NinaHerrmann
Copy link
Contributor

Please remember that this is not our fulltime job. @TamaroWalter will probably look into that tomorrow.

@TamaroWalter TamaroWalter self-assigned this Jul 18, 2024
@TamaroWalter
Copy link
Contributor

Hello @pejhab,
thank you for reporting an issue. I tried to reproduce your problem on my system and indeed, there is a bug while formating embedded videos in Moodleoverflow. I am on this issue!

@TamaroWalter
Copy link
Contributor

Hello @pejhab,
I committed a fix in #191 and embedded videos are now working on my moodle systems (M4.4 and M4.1). If you want, you can add the changes to your system and test if it works too. If you do, please report it so I can either continue searching for the bug or add the changes to the productive system.
Regards
Tamaro

@pejhab
Copy link
Author

pejhab commented Jul 18, 2024

Hello,
I replaced the two files with the modified versions and Generico video embedding, standard video embedding, and glossary auto-linking all seem to be working properly again.
Thanks for your time and effort!

@Laur0r
Copy link
Contributor

Laur0r commented Aug 27, 2024

Hello, these problems should be fixed with v4.4-r3.

@Laur0r Laur0r closed this as completed Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants