Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository.__init__ (possibly others) missing os.PathLike typing #1307

Open
warriorstar-orion opened this issue Jun 15, 2024 · 0 comments
Open

Comments

@warriorstar-orion
Copy link

Support for PathLikes was added in #990. However, it doesn't appear the typing for some of the affected methods were updated. Repository.__init__ was the one I caught, but there may be more (which is why this isn't just a PR, I didn't want to make this one change and end up missing others).

pygit2/pygit2/repository.py

Lines 1523 to 1528 in 5b27dee

class Repository(BaseRepository):
def __init__(
self,
path: typing.Optional[str] = None,
flags: RepositoryOpenFlag = RepositoryOpenFlag.DEFAULT,
):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant