Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connmgr: flaky TestMultiplePeers #1324

Closed
marten-seemann opened this issue Feb 7, 2022 · 3 comments · Fixed by #2128
Closed

connmgr: flaky TestMultiplePeers #1324

marten-seemann opened this issue Feb 7, 2022 · 3 comments · Fixed by #2128
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@marten-seemann
Copy link
Contributor 

  === RUN   TestMultiplePeers
      decay_test.go:220: wrong value; expected = 2670; got = 2671
  --- FAIL: TestMultiplePeers (1.08s)
@marten-seemann marten-seemann added the kind/bug A bug in existing code (including security flaws) label Feb 7, 2022
@marten-seemann marten-seemann mentioned this issue Mar 10, 2022
Merged
@marten-seemann marten-seemann changed the title flaky TestMultiplePeers connmgr: flaky TestMultiplePeers May 19, 2022
@schomatis
Copy link

Assigning myself.

@schomatis

This comment was marked as outdated.

Sign in to view
@schomatis schomatis mentioned this issue Jul 7, 2022
Closed
@schomatis
Copy link

@marten-seemann I think we can close this issue.

I haven't been able to reproduce the error and with a controlled number of elapsed decaying ticks (through the mock clock of #1354) this shouldn't happen again, and if it does it would no longer be a flake but an actual bug (this will be made even more explicit now with #1642).

@marten-seemann marten-seemann mentioned this issue Feb 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

connmgr: Use eventually equal helper in connmgr tests libp2p/go-libp2p
2 participants
@marten-seemann @schomatis