Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swarm: emit PeerConnectedness event #1571

Closed
marten-seemann opened this issue May 27, 2022 · 0 comments · Fixed by #1574
Closed

swarm: emit PeerConnectedness event #1571

marten-seemann opened this issue May 27, 2022 · 0 comments · Fixed by #1574
Assignees
@marten-seemann
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful kind/enhancement A net-new feature or improvement to an existing feature

Comments

@marten-seemann
Copy link
Contributor

Currently, both the blank host and the basic host run identical code to emit PeerConnectedness events. This logic should probably live in the swarm instead.

Potential challenge: we'll need to pass the event bus to the swarm constructor somehow.
@marten-seemann marten-seemann added kind/enhancement A net-new feature or improvement to an existing feature exp/intermediate Prior experience is likely helpful effort/hours Estimated to take one or several hours labels May 27, 2022
@marten-seemann marten-seemann self-assigned this May 28, 2022
@marten-seemann marten-seemann mentioned this issue May 28, 2022
Merged
@marten-seemann marten-seemann changed the title emit PeerConnectedness event from the swarm swarm: emit PeerConnectedness event Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marten-seemann marten-seemann

Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

swarm: emit PeerConnectedness event from swarm instead of from hosts libp2p/go-libp2p
1 participant
@marten-seemann