Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

Query logic overhaul #233

Closed
Tracked by #3905
achingbrain opened this issue Oct 1, 2021 · 3 comments · Fixed by #237
Closed
Tracked by #3905

Query logic overhaul #233

achingbrain opened this issue Oct 1, 2021 · 3 comments · Fixed by #237

Comments

@achingbrain
Copy link
Member

achingbrain commented Oct 1, 2021

Dist Paths

JS uses disjoint paths, go does not. We could ignore this for now and just lock to 1 (it might be interesting in the future to see how disjoint path performance behaves if we can get comparable performance with go on 1 path)

Evaluate Lookup/Query Logic

Problems:

  • Key queries are really inconsistent right now. We should always be using sha256 hashes of the multihash but the APIs are currently inconsistent. This needs to get cleaned up. All APIs should just take multihashes.
    Verify go and js are generating the same hashes
  • FindProviders should yield as they are found
@achingbrain
Copy link
Member Author

Related: libp2p/js-libp2p#983

@vasco-santos
Copy link
Member

it might be interesting in the future to see how disjoint path performance behaves

yes, I think this would be good. Both to compare with go and using something like testground

@achingbrain
Copy link
Member Author

Hopefully @hacdias will be able to help us with Testground soon!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants