ambient peer discovery in the browser

[tabcat]

• Version: libp2p@0.45.9

• Platform: Linux joemama 5.19.0-45-generic # 46~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Wed Jun 7 15:06:04 UTC 20 x86_64 x86_64 x86_64 GNU/Linux
• Browser: Brave (Chromium)

• Subsystem: Relay, Pubsub

Severity: High

Description:

Clients are not discovering each other passively. After connecting them manually and subscribing to the same pubsub topic; peers become pubsub peers but never add each other to the topic mesh.

Steps to reproduce the error:

https://github.com/tabcat/libp2p-pubsub

[tabcat]

Getting an error when calling pubsub.publish

Uncaught TypeError: Cannot read properties of undefined (reading 'Message')
    at buildRawMessage (buildRawMessage.ts:43:1)
    at GossipSub.publish (index.ts:2050:1)
    at <anonymous>:1:30

Looks like RPC is undefined.

https://github.com/ChainSafe/js-libp2p-gossipsub/blob/89c82f6c06ee29e0b7c84ef4165ba38ff672394c/src/utils/buildRawMessage.ts#L40

Probably due to bundler?

[tabcat]

Most of the pubsub mesh issue was due to the bundler resolving .cjs files. Related: facebook/create-react-app#12700

However the passive peer discovery is still not working for the circuit-relay topology. Also seeing one side of pubsub not seeing the remote subscriber.

[bradwbradw]

I was trying to get browser peers to discover eachother for a really long time during the last hackFS, never was successful. Seeing this issue pop up makes me feel less like I was shooting myself in the foot, so thank you.

I forked your repro and added some simple GUI: https://github.com/bradwbradw/libp2p-pubsub

There's two instances of libP2P, both available in window as libp2p1 and libp2p2

You can see, for each instance: the self peer ID, the peer store, and a list of peers that have been discovered

My system:
MacOS Monterey 12.6.7
Firefox
NodeJS v19.9.0

Also unable to see the peers discover eachother via the relay node.

I would expect to see two peers in the peer store and in the discovered peers list. But only seeing itself.

Also want to point out, there is some kind of race condition whereby starting and stopping the relay server / refreshing the browser window using different timings causes a crash, but it's pretty hard to reproduce reliably:

When it is reproduced, refreshing the browser consistently shows the crash. Restarting the relay server can fix it.

(note: I had a larger post before but found that most of the notes I made were just to do with how libp2p was being integrated into React. In the current state react is happy with no linting warnings, and it's behaving quite consistently, and React.StrictMode is off. I did get it to discover the other peer at one point while thrashing about in the code but I haven't been able to get that state back.)

[tabcat]

Working fine for me now, must have been doing something wrong.

[maschad]

Thanks for following up @tabcat :)

@bradwbradw I took a look at your peer discovery config and I noted that you're using gossipsub but with no configuration, to avoid going into the complexities of gossipsub, have you tried seeing if you are able to discover peers using a bootstrap node and then connect that way? You can take a look at this example as a starting point, but I think the issue @tabcat raised is unrelated to what you are trying to solve.

If you are still having problems after trying that, feel free to open an new issue using our issue template

[bradwbradw]

@tabcat are you able to share what you were doing wrong or what you discovered?

Thanks @maschad I will take another look and open a new issue if need be

[tabcat]

@bradwbradw turning on debug logs for circuit-relay helped