Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deactivating dns-feature doesn't compile #1952

Closed
gnunicorn opened this issue Feb 9, 2021 · 2 comments · Fixed by #1927
Closed

deactivating dns-feature doesn't compile #1952

gnunicorn opened this issue Feb 9, 2021 · 2 comments · Fixed by #1927

Comments

@gnunicorn
Copy link
Contributor

In substrate we are (effectively) building libp2p (0.34.0 but I can also reproduce it on latest master) for sc-network as/with

cargo build --no-default-features --features "identify,kad,mdns,mplex,noise,ping,request-response,tcp-async-io,websocket,yamux"

Which fails, dns is not activated but used by build_tcp_ws_noise_mplex_yamux:

   Compiling libp2p v0.35.0 (/home/ben/Dev/parity/rust-libp2p)
error[E0433]: failed to resolve: use of undeclared crate or module `dns`
   --> src/lib.rs:293:25
    |
293 |         let transport = dns::DnsConfig::new(tcp)?;
    |                         ^^^ use of undeclared crate or module `dns`

error: aborting due to previous error

This probably didn't show up earlier, as we rarely build that package separately and in node/cli build it with default-features enabled. Adding dns to the feature list and all goes fine.

@romanb
Copy link
Contributor

romanb commented Feb 9, 2021

I think this has been addressed along the way in #1927, which can hopefully be merged and released soon. Of course, if this issue has any urgency, we could patch it separately before #1927 is merged.

@gnunicorn
Copy link
Contributor Author

no urgency. the now here linked patch shows that it actually originated from a wrong specification of features in substrate, so adding dns there was all that's needed for us to continue. The issues state here is still correct though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants