Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add check that ensures we bump a dependency's version #4126

Closed
thomaseizinger opened this issue Jun 27, 2023 · 2 comments
Closed

ci: add check that ensures we bump a dependency's version #4126

thomaseizinger opened this issue Jun 27, 2023 · 2 comments

Comments

@thomaseizinger
Copy link
Contributor

thomaseizinger commented Jun 27, 2023

In #4107, we forgot to bump the patch version of libp2p-identity. This is something that happened several times already. Just after we release a crate, we need to bump the patch version on the next PR that makes it into master.

We should add a CI check that prevents this from happening. There are several ways of solving this but I am thinking:

  • Add an additional step to our per crate job that is conditional on the CHANGELOG.md of the crate. The assumption here is that if we touch the changelog, we also need to bump the version if it hasn't happened yet.
  • As a next step, fetch the current version from crates.io. If it is different from our version in the manifest, fail CI.

Alternative ideas welcome.

@thomaseizinger
Copy link
Contributor Author

  • Add an additional step to our per crate job that is conditional on the CHANGELOG.md of the crate. The assumption here is that if we touch the changelog, we also need to bump the version if it hasn't happened yet.

Actually, we should probably just check if anything within that crate's directory changed.

@thomaseizinger
Copy link
Contributor Author

Duplicate of #4367.

@thomaseizinger thomaseizinger closed this as not planned Won't fix, can't repro, duplicate, stale Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant