Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The return value of libp2p::build_* cannot be .boxed() #783

Closed
tomaka opened this issue Dec 16, 2018 · 2 comments
Closed

The return value of libp2p::build_* cannot be .boxed() #783

tomaka opened this issue Dec 16, 2018 · 2 comments
Labels
difficulty:hard difficulty:moderate priority:important The changes needed are critical for libp2p, or are blocking another project

Comments

@tomaka
Copy link
Member

tomaka commented Dec 16, 2018

Calling libp2p::build_development_transport(...).boxed() fails to compile because of trait requirements.
@tomaka tomaka added priority:important The changes needed are critical for libp2p, or are blocking another project difficulty:moderate difficulty:hard labels Dec 16, 2018
@bitkis bitkis mentioned this issue Sep 3, 2019
Closed
@romanb
Copy link
Contributor

romanb commented Oct 6, 2020 •
edited
Loading

With #1783 the development transports are essentially already fully .boxed() (the StreamMuxer was already boxed before) which could even be reflected in the return type instead of using an opaque impl return type.

@romanb romanb mentioned this issue Oct 15, 2020
Merged
@romanb
Copy link
Contributor

romanb commented Oct 16, 2020

Obsoleted by #1794.

@romanb romanb closed this as completed Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:hard difficulty:moderate priority:important The changes needed are critical for libp2p, or are blocking another project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@romanb @tomaka