wrong path for pbjs and pbts in our sample app

[katsutoxin]

Customer reported that they got some error when following the quick start guide

Here are steps to reproduce the problem....

# download sample
kalix quickstart download customer-registry-javascript

# build the sample
cd customer-registry
npm install
npm run build

We will see the following errors

/bin/sh: /xxx/customer-registry/node_modules/.bin/pbjs: No such file or directory

There are two possible solutions:

solution 1:

Add protobufjs@6.11.3 as devDependencies in in https://github.com/lightbend/kalix-javascript-sdk/blob/main/samples/js/js-customer-registry-quickstart/package.json

solution 2:

Modify the pbjs path in kalix-script.js to ./node_modules/@grpc/proto-loader/node_modules/.bin/pbjs, and the similar to pbts
https://github.com/lightbend/kalix-javascript-sdk/blob/main/npm-js/kalix-scripts/bin/kalix-scripts.js#L103-L115

One thing I feel confused is that, in https://github.com/lightbend/kalix-javascript-sdk/blob/main/samples/js/js-customer-registry-quickstart/package.json It uses kalix-script in build. However, in https://github.com/lightbend/kalix-javascript-sdk/blob/main/samples/js/js-customer-registry/package.json , it uses compile-descriptor for build instead of kalix-script, why are they different???

@jroper and @octonato , I know you are working on this area recently , especially the issue #398 Any comment on this issue?

[katsutoxin]

Hi @octonato ,

I heard that you made a change recently? Will releasing your change to kalix quickstart download customer-registry-javascript fix the problem?

[aklikic]

I have the same problem when kickstarting a project using:
npx @kalix-io/create-kalix-entity@latest my-entity

[aklikic]

So I used your solution 1 but also had to add it to dependencies when running on Kalix

[katsutoxin]

Hi @pvlugter ,

Do you have any suggestion how to fix this problem?

[pvlugter]

It's awkward that grpc-js changed its dependencies in a patch version. Otherwise it would be fine.

The SDK dependencies for grpc-js and proto-loader were already changed to pinned versions in #401. So I think it should just require a release of the SDK with that change.

[pvlugter]

Released version 1.0.1, which should work now.

[pvlugter]

Quickstart downloads may be cached for a while, so check that it's the latest with SDK 1.0.1.

[aklikic]

I have updated to 1.0.1 and when I do npm run deploy I get this error:

#13 7.643 /home/node/node_modules/@kalix-io/kalix-scripts/bin/kalix-codegen-js.bin: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /home/node/node_modules/@kalix-io/kalix-scripts/bin/kalix-codegen-js.bin)
#13 7.643 /home/node/node_modules/@kalix-io/kalix-scripts/bin/kalix-codegen-js.bin: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /home/node/node_modules/@kalix-io/kalix-scripts/bin/kalix-codegen-js.bin)
#13 7.643 Running Invoking Kalix codegen failed, process: [/home/node/node_modules/@kalix-io/kalix-scripts/bin/kalix-codegen-js.bin], args: [--proto-source-dir,./proto,--source-dir,./src,--generated-source-dir,./lib/generated,--test-source-dir,./test]
#13 7.643 
#13 7.643 /home/node/node_modules/@kalix-io/kalix-scripts/bin/kalix-scripts.js:235
#13 7.643     throw `${actionDescription} failed.`;
#13 7.643     ^
#13 7.644 Invoking Kalix codegen failed.
#13 7.644 (Use `node --trace-uncaught ...` to show where the exception was thrown)

[aklikic]

FYI npm run test is working

[pvlugter]

Ok, so that's the docker build. We'll need to look at the build for the linux codegen binary. We must have a mismatch between the machine image used in CI for building this, and the base docker image.

[aklikic]

Is there any timeline for this? Tnx

[katsutoxin]

I update the PR #403 to fix this problem. I feel that we need to set the new path for pbts and pbjs. anyone want to review it

[pvlugter]

@katsutoxin, the dependency issue should be fixed.

Is there any timeline for this?

I'll look at aligning these builds and publish another release today.

[pvlugter]

@aklikic released 1.0.2 with a newly built codegen binary for linux, for the docker build. Works for me now.