Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientCallable.call() signature #23

Open
zlangbert opened this issue Feb 3, 2015 · 6 comments
Open

ClientCallable.call() signature #23

zlangbert opened this issue Feb 3, 2015 · 6 comments

Comments

@zlangbert
Copy link

This is a bit of a nitpick but when call() is expanded it includes a call to Future.map which requires an execution context. My IDE kept deleting the import because it didn't know it needed it. Would it be possible to change the signature of call() to something like call(implicit executor: ExecutionContext)?

@lihaoyi
Copy link
Owner

lihaoyi commented Feb 3, 2015

Sure

@lihaoyi
Copy link
Owner

lihaoyi commented Feb 3, 2015

Probably call()(implicit executor: ExecutionContext) to be source-compatible, unless you want to remove the parens at the end of the call, which is probably unimportant

@zlangbert
Copy link
Author

No you're right, that makes more sense. Thanks!

@caente
Copy link

caente commented Mar 23, 2015

On this note, is there a way to pass the ExecutionContext explicitly to call?

@lihaoyi
Copy link
Owner

lihaoyi commented Mar 23, 2015

Not unless we change the signature =P Which nobody has done yet...

@Daxten
Copy link

Daxten commented Feb 2, 2017

#57 closes this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants