-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transform-decorators-legacy bug #13
Comments
Thanks for the report, it looks like the first is probably an edge case that I missed. I'm thinking that class properties aren't currently working on classes that have parent classes. Does that seem likely to be the issue for the class that is throwing I think your second issue may be a side-effect of your "fix" first the first. Adding |
Okay, I've pushed out a |
Excellent! I've done the steps you suggested and tested my build with Babel 6...and it works! I'm going to unsubscribe from https://phabricator.babeljs.io/T2645 since I have what I need now. If you want to write a quick note there to respond to my question about the repurposing of the issue, it might help people decide to unsubscribe (I also find it a little spammy / chatty...it would be great if there weren't notification emails for people being added and removed be default). I really appreciate you writing this plugin to get people over to Babel 6! Onto the future... |
From: https://phabricator.babeljs.io/T2645
@loganfsmyth: I tried on the day of the latest release a few days ago, but had to stop because I couldn't get it to work with mobservable. I'm trying again today and trying to track down the problems....
First problem:
Uncaught Error: Decorating class property failed. Please ensure that transform-class-properties is enabled
my .babelrc has stage-1 enabled:If I manually add transform-class-properties (maybe I'm configuring incorrectly?) I do not get the warning:
but I run into a second problem:
The world decorator is added, but the hello one is missing from the class decoration section. So it looks like there is a change / bug in how decorators handle class properties...(other more simple ones like
@observable hello = null;
are skipped too)The text was updated successfully, but these errors were encountered: