Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Milliseconds support #5

Closed
fabiospampinato opened this issue Jun 3, 2019 · 5 comments
Closed

Milliseconds support #5

fabiospampinato opened this issue Jun 3, 2019 · 5 comments

Comments

@fabiospampinato
Copy link

An {ms} token for milliseconds would be great to have.
@lukeed
Copy link
Owner

lukeed commented Jun 4, 2019 •
edited
Loading

Nice, yeah I think so. But it looks like fff is a much more common format (C#, .NET, java, matlab, etc). That also plays nicer with the existing code.

Sound reasonable?

@fabiospampinato
Copy link
Author

I've probably never met the "fff" token before, but I guess it would work. The nice thing about it is that it better represents how many numbers are going to get printed.

@lukeed
Copy link
Owner

lukeed commented Jun 4, 2019

Aye, that's exactly how every other lang treats it & how the current code determines the number of digits to slice :)

Will do this now

@lukeed lukeed closed this as completed in 22ada81 Jun 4, 2019
@fabiospampinato
Copy link
Author

Super quick, thanks!

@lukeed
Copy link
Owner

lukeed commented Jun 4, 2019

No problem! Thanks for the idea 👍 Now released as 1.1.0~!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabiospampinato @lukeed