Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name NA contains a capitalized acronym #123

Open
jplatte opened this issue Apr 9, 2021 · 1 comment
Open

Name NA contains a capitalized acronym #123

jplatte opened this issue Apr 9, 2021 · 1 comment

Comments

@jplatte
Copy link
Contributor

jplatte commented Apr 9, 2021

In 0d73235 I silenced a clippy lint. It would probably good to fix it instead, but I didn't want to do any breaking changes just for clippy without really understanding the code.

@DmitrySamoylov Do you think the two NA enum variants can safely be renamed to Na (or maybe NotApplicable if that's what NA stands for here)?
@jplatte
Copy link
Contributor Author

jplatte commented Apr 20, 2021 •
edited
Loading

I'm not sure the whether occurrence above was generated code, but this also triggers for a lot of generated code. A proper fix will take some time, but it should absolutely be possible to use Rust's captialization convention here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jplatte