Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding multiple products to cart with custom options GraphQL fails to compare custom options properly #39178

Open
1 of 5 tasks
dan-edan opened this issue Sep 17, 2024 · 2 comments
Assignees
Labels
Issue: ready for confirmation Reported on 2.4.7-p2 Indicates original Magento version for the Issue report.

Comments

@dan-edan
Copy link

Preconditions and environment

Magento version 2.4.7-p2
PHP 8.3
Sample data installed via CLI
Add text field custom option to a product (I used SKU: 24-MB01)

Steps to reproduce

  1. Send graphQL to init cart
mutation initCart {
  createGuestCart {
    cart {
      id
    }
  }
}
  1. Get the custom option UID from the product query
query ProductByUrl($url: String!) {
  products(filter: { url_key: { eq: $url } }, pageSize: 1) {
    items {
      uid
      name
      sku
      ... on CustomizableProductInterface {
        options {
          title
          uid
        }
      }
    }
  }
}

Using these variables

{
  "url": "joust-duffle-bag"
}
  1. With the cart ID from the previous command, send the graphQL to add products. This will be the same product but with different custom options.
mutation AddProductsToCart($cartId: String!, $cartItems: [CartItemInput!]!) {
  addProductsToCart(cartId: $cartId, cartItems: $cartItems) {
    cart {
      items {
        product {
          name
          sku
        }
        ... on SimpleCartItem {
          customizable_options {
            customizable_option_uid
            label
            values {
              customizable_option_value_uid
              value
            }
          }
        }
        quantity
      }
    }
    user_errors {
      code
      message
    }
  }
}

Using these variables

{
  "cartId": "<CART-ID>",
  "cartItems": [
    {
      "sku": "24-MB01",
      "quantity": 1,
      "entered_options": [
        {
          "uid": "<CUSTOM-OPTION-ID>",
          "value": "This is a test 1"
        }
      ]
    },
    {
      "sku": "24-MB01",
      "quantity": 1,
      "entered_options": [
        {
          "uid": "<CUSTOM-OPTION-ID>",
          "value": "This is a test 2"
        }
      ]
    }
  ]
}

Expected result

The cart should contain two products, each with a qty of 1, and both should have the respective custom option value.

Actual result

The cart contains just one item with a qty of 2, and the custom option value is just that of the first item sent in the variables.

Additional information

Adding products one at a time works as expected. However, performance suffers greatly.

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Sep 17, 2024

Hi @dan-edan. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.7-p2 Indicates original Magento version for the Issue report. label Sep 18, 2024
@engcom-Bravo engcom-Bravo self-assigned this Sep 18, 2024
Copy link

m2-assistant bot commented Sep 18, 2024

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: ready for confirmation Reported on 2.4.7-p2 Indicates original Magento version for the Issue report.
Projects
Status: Ready for Confirmation
Development

No branches or pull requests

2 participants