Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect gap in DssSpell.t.base.sol #362

Open
ghost opened this issue Aug 23, 2023 · 4 comments
Open

Incorrect gap in DssSpell.t.base.sol #362

ghost opened this issue Aug 23, 2023 · 4 comments

Comments

@ghost
Copy link

ghost commented Aug 23, 2023

          Haven't been really following the concrete numbers, but I think the 30M shouldn't be part of the gap change, as that 30M increment in `RWA-2` has the corresponding of the global debt ceiling as well. However the -100M from `CRVV1ETHSTETH-A` is correct as the global debt ceiling was reduced in that number when the local debt ceiling was already 0. So the reference value IMO (and just following the logic at a high level point of view) should be 650.

Originally posted by @sunbreak1211 in #360 (comment)

@ghost
Copy link
Author

ghost commented Aug 23, 2023

@SidestreamColdMelon @0xdecr1pto for attention

@0xdecr1pto
Copy link
Contributor

0xdecr1pto commented Aug 24, 2023

@SidestreamColdMelon @amusingaxl @sunbreak1211
I found that we can't decrease the offset for 30m, because this test starts failing

assertTrue(sums[0] + 2 * values.line_offset * RAD >= vat.Line(), "TestError/vat-Line-3");

sum of ilks = 5784999296615681261561073747403742780250307433758853657 (in RAY)
vat.Line() = 7119856657556728658157855938384546615580869737094691855 (in RAY)

the diff between is 1_334 m

So we can decrease offset for 13m max to 668m

Not sure what was wrong probably offset was messed up at some point

@amusingaxl
Copy link
Contributor

Honestly, I believe we could set Line to a ridiculously high value and forget about it.
Individual lines for ilks already do the job of controlling this. Furthermore, with the new Allocation System, SubDAOs will have 1T debt ceilings managed by AutoLine, so this global Line will make even less sense.

@sunbreak1211
Copy link
Contributor

I personally think the same, Line should be set to max_uint256 and forget about these issues if not gonna be used as a lower value than the sum of ilk lines.
Some devs believed it was another security restriction and was worth to keep it but I could never really appreciate the purpose.
Btw take into account the 1T is what the oracle + gem supply will allow as max debt. However the debt ceiling will be probably much less (using or not autoline).

@0xdecr1pto 0xdecr1pto mentioned this issue Aug 29, 2023
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants