Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo of Manticore Search #1556

Closed
sanikolaev opened this issue Nov 3, 2023 · 25 comments
Closed

Demo of Manticore Search #1556

sanikolaev opened this issue Nov 3, 2023 · 25 comments
Assignees

Comments

@sanikolaev
Copy link
Collaborator

We have some great tools for learning Manticore Search like the manual which is powered by Manticore Search and online courses. Plus, there are neat little demos on the play platform (like this one: https://play.manticoresearch.com/didyoumean/).

I'm thinking it's time we build a bigger demo. How about an app that uses Manticore to search for things like songs, movies, or news articles? This way, people can see a bigger project working with Manticore. We can share the app's code and also write a simple guide on how to create it.

Here's the plan:

  • Pick a topic: we should start with something fun that shows what Manticore can do.
  • Make the demo: develop a simple yet cool app. It should be easy for beginners to get and also show some advanced tricks for the others.
@AbstractiveNord
Copy link
Contributor

  • Text articles is great, especially if they contain source code opened.
  • In case of videos, if this type of content is planned, would be wonderful if ManticoreSearch will have series like this. Videos usually more attractive for newcomers. May be effective even only highlighting interactive demos with videos.

@sanikolaev
Copy link
Collaborator Author

Further ideas/plans:

@sanikolaev
Copy link
Collaborator Author

Empty result in this case:

image

@sanikolaev
Copy link
Collaborator Author

The Open/Closed states should be hidden/blocked in case of "Comments".

image

@sanikolaev
Copy link
Collaborator Author

sanikolaev commented Jan 11, 2024

  • Let's add ... around the highlighting passages:
image

@sanikolaev
Copy link
Collaborator Author

sanikolaev commented Jan 11, 2024

  • Bug: not all comments get fetched from Github (e.g. search by "fixed in").

@sanikolaev
Copy link
Collaborator Author

sanikolaev commented Jan 11, 2024

  • TODO: Reset all advanced filters when clicking on "Comments".

@sanikolaev
Copy link
Collaborator Author

sanikolaev commented Jan 11, 2024

More bugs:

  • Labels are not displayed
  • "Everywhere + Closed + Sort by: most commented" displays 0 results

@sanikolaev
Copy link
Collaborator Author

sanikolaev commented Jan 11, 2024

  • add a space:
image

@sanikolaev
Copy link
Collaborator Author

sanikolaev commented Jan 11, 2024

  • This is displayed in black in Chrome and Safari:
    image

@sanikolaev
Copy link
Collaborator Author

sanikolaev commented Jan 11, 2024

  • order facets by count
  • let's include comments when filtering by author:
    image

@sanikolaev
Copy link
Collaborator Author

Check if we can integrate with https://github.com/ankane/onnxruntime-php

Blocked by manticoresoftware/manticoresearch-php#184

@sanikolaev
Copy link
Collaborator Author

sanikolaev commented Jan 12, 2024

  • Filter by author works wrong:
    image

@sanikolaev
Copy link
Collaborator Author

sanikolaev commented Jan 12, 2024

  • Filters are not reflected in the UI:
    image

@sanikolaev
Copy link
Collaborator Author

sanikolaev commented Jan 12, 2024

  • Let's hide comments when the selected filters can't be applied to comments:
    image

@sanikolaev
Copy link
Collaborator Author

sanikolaev commented Jan 12, 2024

  • In case of the infiinite scrolling, wrong results get loaded.

@sanikolaev
Copy link
Collaborator Author

sanikolaev commented Jan 15, 2024

  • Let's rtrim the slash:
    image
    Same with quickwit-oss/quickwit/
  • Exception, potentially a breach:
    image
  • "issues & PRs"
    image
  • <span> shouldn't be there:
    image
  • Can't reset the query if you do:
    • search for something
    • Advanced -> author -> sanikolaev ON
    • Advanced -> author -> sanikolaev OFF
    • Cmd+R to refresh the page
    • "Reset" doesn't reset the query
  • Filter by comments counts and "Search in comments" shouldn't be available at the same time, it doesn't make sense:
    image

@sanikolaev
Copy link
Collaborator Author

sanikolaev commented Jan 16, 2024

  • Remove the quotes mark and think how to deal with this query in general:
    image

    e.g. in case of a syntax error - make another attempt with a query cleaned from special characters (" etc.).

  • FT query is not reset anymore which is good, but:

    • search for something
    • Advanced -> author -> sanikolaev ON
    • Advanced -> author -> sanikolaev OFF
    • Cmd+R to refresh the page
    • Now "Reset" resets the query
  • Filter by comments counts and "Search in comments" can be still used at the same time:

    • Click "Comments"
    • Select "Comments count < 3"
    • Click "Comments" again
    • Select "Comments count < 3" again

@sanikolaev
Copy link
Collaborator Author

sanikolaev commented Feb 1, 2024

  • ... issue: try trimming ...... in the end/beginning replacing that with ...

@sanikolaev
Copy link
Collaborator Author

  • experiment more with the facets UI to make it less confusing (grey out filters that would result in zero results etc.)

@sanikolaev
Copy link
Collaborator Author

sanikolaev commented Feb 12, 2024

What's left before we announce the demo:

@sanikolaev
Copy link
Collaborator Author

sanikolaev commented Feb 20, 2024

Check if we can integrate with https://github.com/ankane/onnxruntime-php

Blocked by manticoresoftware/manticoresearch-php#184

Unblocked.

@sanikolaev
Copy link
Collaborator Author

  • improve exceptions handling, especially the exception which is thrown when the token has exceeded its limit

@donhardman
Copy link
Contributor

I'm currently waiting for a response because I can't use ext-php-rs with the latest PHP 8.3. I need this to move forward with building a tokenizer as an extension in PHP. For more details, you can check out this issue: davidcole1340/ext-php-rs#314

@donhardman
Copy link
Contributor

I believe there's no reason to keep this task open since the main project is complete, and it would be better to apply future iterations in separate tasks and steps. I've divided what we have here into two tasks and will be closing this one:

Vector Search: manticoresoftware/manticore-github-issue-search#10
Features and Extras: manticoresoftware/manticore-github-issue-search#11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants