Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize expressions #20

Open
1ec5 opened this issue Apr 26, 2018 · 5 comments
Open

Localize expressions #20

1ec5 opened this issue Apr 26, 2018 · 5 comments

Comments

@1ec5
Copy link
Contributor

1ec5 commented Apr 26, 2018

adaptPropertyLanguage() should attempt to localize expressions used as text-fields. Currently, it only works for constant strings and style functions.

mapbox/mapbox-gl-js#6197 is a proposal to make label localization a built-in feature of the style specification. In the meantime, mapbox/mapbox-gl-native#11651 has a comprehensive implementation of label localization in Objective-C. While that implementation targets NSExpression’s syntax, the same logic should more or less apply when working with style JSON objects.

/cc @lukasmartinelli @tristen @anandthakker

@andrewharvey
Copy link

Anyone planning on working on this?

@coocy
Copy link

coocy commented Feb 13, 2020

I have forked and made an improved version.
Please check this https://github.com/coocy/mapbox-gl-language/
Demo: http://coocy.github.io/mapbox-gl-language/example/

@andrewharvey
Copy link

@coocy that's great, are you interested in putting together a PR? I can help review it.

@coocy
Copy link

coocy commented Feb 14, 2020

@andrewharvey OK, I'll do this later.

@dmytro-gokun
Copy link

@coocy Do you still plan doing that? Maybe you can use some help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants