Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1022 that was fixed in 2.37.0 is back in 2.38.0 #1078

Closed
classifaddict opened this issue Jul 12, 2021 · 3 comments
Closed

Issue #1022 that was fixed in 2.37.0 is back in 2.38.0 #1078

classifaddict opened this issue Jul 12, 2021 · 3 comments

Comments

@classifaddict
Copy link

jquery.fancytree-all-deps.2.38.0.min.js:1 Fancytree assertion failed
jquery.fancytree-all-deps.2.38.0.min.js:1 Could not access window.localStorage
jquery.fancytree-all-deps.2.38.0.min.js:1 Fancytree@1
jquery.3.6.0.min.js:2 jQuery.Deferred exception: 'undefined' is not an object

Originally posted by @classifaddict in #1022 (comment)

@mar10
Copy link
Owner

mar10 commented Jul 12, 2021

This was supposed to be fixed with f840149.
When does It happen: on load, even when ext-persist is not enabled?
Can you retry with a non-minified version, and share the stack trace.

@classifaddict
Copy link
Author

I'm not using ext-persist and now I realize it is happening with the minified version only.

With the non-minified version I get these warnings only (not the Jquery one) but the result is the expected one:
jquery.fancytree-all-deps.js:1548 Fancytree assertion failed
jquery.fancytree-all-deps.js:1548 Could not access window.localStorage
jquery.fancytree-all-deps.js:1548 Fancytree@1

Note: I'm using wkhtmltopdf, a webkit based PDF rendering engine.

@mar10
Copy link
Owner

mar10 commented Jul 17, 2021

I don't see a reason why the minified version should behave differently.

Anyway, wkhtmltopdf uses a 2012 webkit and is not well supported anymore, also difficult to debug, so I don't want to invest much effort here. I am open to patches though.

As a workaround, you could remove the ext-persist plugin from the minified JS file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants