Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should only raise exception about data being a string if dataType is "json" #417

Closed
Aranad opened this issue Mar 28, 2015 · 2 comments
Closed

Comments

@Aranad
Copy link
Contributor

Aranad commented Mar 28, 2015

I'm writing an extension that lazy loads children from an HTML source and then runs the UL structure through the parseHTML function in the postProcess hook. It doesn't work though because line 2655 in the dfd.done function raises an exception if the data returned from the Ajax call is a string, but this exception should really only occur if the Ajax dataType option is "json".

@mar10
Copy link
Owner

mar10 commented Mar 28, 2015

Could you suggest a pull request?

@Aranad
Copy link
Contributor Author

Aranad commented Mar 29, 2015

Thanks, pull request done. Actually I got it working by returning the response string as a single element array in the Ajax request's dataFilter, but it's much cleaner with the condition added to the exception.

@mar10 mar10 closed this as completed in 4147756 Mar 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants