Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skin bootstrap does not offer drop marker or drop reject #464

Closed
bpromasmb opened this issue Jul 16, 2015 · 1 comment
Closed

Skin bootstrap does not offer drop marker or drop reject #464

bpromasmb opened this issue Jul 16, 2015 · 1 comment

Comments

@bpromasmb
Copy link

[I have submitted a StackOverflow Question about this and I am posting here because I assume this is not yet implemented]

I have a fancytree using the bootstrap skin as well as extensions: ["glyph", "contextMenu", "dnd", "edit"], I have mapped my glyph icons to the correct icons I want to use and everything is looking just fine, except that when I drag a node over other nodes in my tree, there aren't any drop markers (or drop reject markers) to indicate where the node will fall once I drop it. This is very bothersome since the interactions with my tree will rely heavily on drag & drop, however through all my digging around I found no reference to anything related to drop markers in my asset files.

Until I noticed the .css file for my bootstrap skin had the following code:

#fancytree-drop-marker {
    width: 2em;
    position: absolute;
    margin: 0;
}
#fancytree-drop-marker.fancytree-drop-after,
#fancytree-drop-marker.fancytree-drop-before {
    width: 4em;
}

and

div.fancytree-drag-helper.fancytree-drop-reject {
  border-color: red;
}

So, technically, I could work around this by making up my own css for the drop markers and they would behave nicely, but it doesn't seem right to directly edit vendor asset files. I would like to know if there is anything that I overlooked when I implemented the bootstrap skin.

@mar10
Copy link
Owner

mar10 commented Jul 16, 2015

You are right, this is currently missing.
I am reworking the bootstrap css at the moment in a separate branch.
As a workaround, you can add your fixing CSS after the Fancytree bootstrap theme (don't modify the Fancytree css files!)
(If you can offer some nice css, I could integrate it into the standard code)

@mar10 mar10 closed this as completed in 95d16e4 Jul 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants