Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double clicking on arrow with lazy-load causes assertion error #495

Closed
Bringer128 opened this issue Sep 3, 2015 · 2 comments
Closed

Double clicking on arrow with lazy-load causes assertion error #495

Bringer128 opened this issue Sep 3, 2015 · 2 comments

Comments

@Bringer128
Copy link

Example JSFiddle:
http://jsfiddle.net/tasn7jzg/1/

To reproduce in the above fiddle, either double-click on the arrow in the node or click the "Cause error" button which does two clicks with JQuery synchronously.

The problem:
Double clicking on the arrow (class="fancytree-expander") with lazy-loading enabled causes a race condition, where the 2nd click occurs before the first lazy-loaded request completes. This logs an error in the console and fires any window.onerror handlers in the consuming application's UI.

This happens fairly regularly as expanding a node can be done by clicking the arrow once, or by double-clicking any of the other elements in the containing span. As people double-click to expand they occasionally miss the text or icon and hit the arrow.

@mar10 mar10 closed this as completed in dc1146d Sep 3, 2015
@Bringer128
Copy link
Author

That was quick, thanks!

@mar10
Copy link
Owner

mar10 commented Sep 4, 2015

No problem. Your description and fiddle helped to fix it. Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants