Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bug in table extension #681

Closed
meterlongcat opened this issue Feb 6, 2017 · 2 comments
Closed

Minor bug in table extension #681

meterlongcat opened this issue Feb 6, 2017 · 2 comments

Comments

@meterlongcat
Copy link

Good morning,

There's a minor bug in the findPrevRowNode function of the table extension. The while loop's condition is while(prev.children), which evaluates to true if children is empty (e.g. []). When this occurs the variable last is then assigned null, which throws a null pointer at if(!last.tr).

You can simply change the while loop to while(prev.children && prev.children.length) to fix this.

Browser: Google Chrome 56.0.2924.87 on Win7

Kind Regards,
MLC

@meterlongcat
Copy link
Author

Turns out this is a duplicate of #531 , but considering it wasn't fixed there I'd like to request it still be fixed under this issue.

Many Thanks,
MLC

@mar10
Copy link
Owner

mar10 commented Feb 7, 2017

Thanks.
The missing information in #531 was, that it only happens if lazy: true is passed as well:

{title: "Sub-item 2.2", key: "node2.2", lazy: true, children: [] }

@mar10 mar10 closed this as completed in a3c57ed Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants