Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation bug when expanding/collapsing nodes #746

Closed
romant-1 opened this issue Jul 1, 2017 · 5 comments
Closed

Animation bug when expanding/collapsing nodes #746

romant-1 opened this issue Jul 1, 2017 · 5 comments
Labels
bug css stale Flagged by stalebot

Comments

@romant-1
Copy link

romant-1 commented Jul 1, 2017

Hi guys,
There is an animation bug when expanding/collapsing tree nodes. The container of the node that's being expanded/collapsed seems to be by approx. 15px wider than the parent tree container. This is happening only during the animation phase. Please see the attached images to see the issue.

animation-bug-chrome
animation-bug-firefox

To reproduce the issue just load the following URL in Chrome and expand/collapse any node. The issue will be visible on the right hand side of the element which contains the tree.

This happened to me in In Chrome (Version 59.0.3071.115) and Firefox (Version 54.0), I haven't tried other browsers.

Regarding the version of JQuery , Fancytree, etc. it's all obviously available on the test page.

This is pretty annoying in cases when there is another element(s) next to the tree as every time when the node expanding/collapsing animation is happening all the elements next to the tree are pushed to the right a bit. This issue seems to be happening only if the tree container doesn't have any fixed width specified - giving it a fixed width possibly doesn't fix the issue but just hides it.

Hopefully this won't be too difficult to fix.

@CookieJon
Copy link

CookieJon commented Jul 16, 2017

Hi.

I had the same problem, and came up with a quick, hacky workaround that might help you while you're waiting for this issue to be addressed properly. In my case, the tree's container width was actually being pushed a bit each time a folder was animating its expand or collapse.

So I just added the following CSS class to my page, after the FancyTree styles are included, and now it works just fine...

ul.ui-effects-placeholder { width:10px !important; }

NB: The order of inclusion might not matter, !important is probably not necessary, and 10px was just a random pick which worked for me with the expand/collapse folder animations. (I didn't spend too much time investigating the why's and wherefore's, just wanted a quick fix and this seems to do the job.)

Good luck!

@romant-1
Copy link
Author

Thanks heaps @CookieJon, much appreciated. I ended up with a similar hack, a proper solution would be definitely better.

@dvstans
Copy link

dvstans commented May 9, 2018

FYI, I just ran into this same issue with folder open/close animation - so still not addressed. @CookieJon's hack seems to work.

@stale
Copy link

stale bot commented Oct 22, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 22, 2019
@mar10 mar10 added stale Flagged by stalebot and removed wontfix labels Oct 22, 2019
@stale stale bot removed the stale Flagged by stalebot label Oct 22, 2019
@stale
Copy link

stale bot commented Mar 14, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Flagged by stalebot label Mar 14, 2020
@stale stale bot closed this as completed Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug css stale Flagged by stalebot
Projects
None yet
Development

No branches or pull requests

4 participants