Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag-and-Drop RTL issue #845

Closed
JavaTMP opened this issue Mar 16, 2018 · 1 comment
Closed

Drag-and-Drop RTL issue #845

JavaTMP opened this issue Mar 16, 2018 · 1 comment

Comments

@JavaTMP
Copy link

JavaTMP commented Mar 16, 2018

Hi Martin,
I hope you are good and fine and thank you again for your effort and time for making this plugin meaningful and important.

Expected and Actual Behavior

drop Marker offset should be on the right for RTL trees.

Steps to Reproduce the Problem

  1. use the same code from default example http://wwwendt.de/tech/fancytree/demo/sample-ext-dnd.html
  2. update it to be RTL.
  3. try to drag and drop node the drop marker stay on the left instead of right.

Demos: (sorry for not providing jsFiddlers):
LTR working as expected demo : http://demo.javatmp.com/JavaTMP-Static-Ajax/#pages/plugins/tree/fancytree/drag-and-drop-fancytree.html
RTL not working as expected demo: http://demo.javatmp.com/JavaTMP-Static-Ajax-RTL/#pages/plugins/tree/fancytree/drag-and-drop-fancytree.html

So is it something we should modify from our side or the plugin should offset the marker from the right in RTL version.

@mar10 mar10 added the bug label Mar 18, 2018
@mar10
Copy link
Owner

mar10 commented Mar 18, 2018

I think this should be fixed in the core code, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants