Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Childcounter Extension doesn't work with custom icons #850

Closed
KSDaemon opened this issue Apr 6, 2018 · 1 comment
Closed

Childcounter Extension doesn't work with custom icons #850

KSDaemon opened this issue Apr 6, 2018 · 1 comment
Labels

Comments

@KSDaemon
Copy link

KSDaemon commented Apr 6, 2018

Thanks for contributing :-) — Thanks for your work! :)

As i can see Childcounter Extension doens't show badges if it is used with custom icons.
I think the problem is in 94 line of jquery.fancytree.childcounter.js — because it is trying to append badge to $("span.fancytree-icon", node.span) which doesn't exist in case of using custom icons.

@mar10 mar10 added the bug label Apr 6, 2018
@mar10
Copy link
Owner

mar10 commented Apr 7, 2018

You are right, I was missing that. Thanks!

@mar10 mar10 closed this as completed in bee2ede Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants