Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With quicksearch enabled, does not search for non-Latin characters #909

Closed
efimovkd opened this issue Nov 13, 2018 · 4 comments
Closed

With quicksearch enabled, does not search for non-Latin characters #909

efimovkd opened this issue Nov 13, 2018 · 4 comments
Labels

Comments

@efimovkd
Copy link

Steps to Reproduce the Problem

  1. Enable quicksearch
  2. Tree data contains cyryllic titles (Ex: Узел)
  3. Activate first node
  4. Press character 'у'
  5. Result nothing

http://jsfiddle.net/v2ueL5k3/

Environment

  • Browser type and version: Chrome, FF
  • jQuery and jQuery UI versions: 3.3.1; 1.12.1
  • Fancytree version: 2.30.0
    enabled/affected extensions: no
@efimovkd
Copy link
Author

Probably it is necessary to handle the "keypress"
jquery.fancytree-all.js: 5207 (2.30.0 dist)
to correctly determine the pressed letters.
jquery.fancytree-all.js: 3389-3390
And make an option a regular expression (/\w/.test(whichChar))
jquery.fancytree-all.js: 3409

@mar10 mar10 added the bug label Nov 13, 2018
@mar10
Copy link
Owner

mar10 commented Nov 13, 2018

Hi,
thanks for reporting this. It is not so easy to reproduce without a Cyrillic keyboard I think, but it also can be reproduced with '€'

I was just looking at the same location ;-) I guess we have to use event.key instead of event.which as well...

@mar10 mar10 closed this as completed in 5c27378 Nov 13, 2018
@mar10
Copy link
Owner

mar10 commented Nov 13, 2018

I checked in a potential fix, pls let me if it works for you (either now with the current code from the repo or later, when it get's released).
I only tested with a German keyboard, the special character and Safari so far

@efimovkd
Copy link
Author

By first test it's work! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants