dnd5 - Counter badge shows up, although the drag was cancelled from dragStart callback

[orenstuf]

In some situations I return false from the dragStart callback, to prevent dragging.
If the user tries to drag multiple nodes, the counter badge still shows up, and remains
visible after the drag have been cancelled.

[mar10]

Thank you for contributing! 👍

In order to process your issue, we need some more information, explanation what already was tried and/or concrete data.

A debuggable example (jsFiddle, Plunkr, CodePen, ...) may be helpful.

Please read the Contribution Guidelines for some hints on how to submit helpful feature requests and bug reports.

[orenstuf]

I have created a plunk to demonstrate the issue: https://plnkr.co/edit/dHTMlOJF46f8RSHrijrM
If you select two nodes and drag them, you will see the counter badge, although the drag is blocked by dragStart.

Notes:

• Temporary fix: manually removing the badge (line 32 in plunk):
  $(node.span).find('.fancytree-childcounter').remove();

• dragEnd is not fired, because the drag is blocked. Looking at the source code at
  dist/jquery.fancytree-all-deps.js, line 9594, I see that dragEnd is responsible for removing the badge:

case "dragend":
	_clearGlobals();
	// data.dropEffect = dropEffect;
	data.isCancelled = dropEffect === "none";
	$dropMarker.hide();
	// Take this badge off of me - I can't use it anymore:
	if ($extraHelper) {
		$extraHelper.remove();
		$extraHelper = null;
	}
	dndOpts.dragEnd(node, data);
	break; 

I'm using:

• jquery 3.4.1
• fancytree from dist/jquery.fancytree-all-deps.js, version 2.30.2
• css from dist/skin-win8/ui.fancytree.css, version 2.30.2

[mar10]

Thank you for making up a sample.
I saw the problem there, and was not able to reproduce it with the latest code: the badge is not created when dragStart returns false. In this case also dragEnd is not called.

So I assume it is fixed with 2.31. It will be released the next days. Please re-openthis issue if it is not fix it for you then.