Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node.navigate($.ui.keyCode.DOWN, false) does not return promise since 2.31 #955

Closed
zadam opened this issue Jun 13, 2019 · 1 comment
Closed
Labels

Comments

@zadam
Copy link

zadam commented Jun 13, 2019

node.navigate($.ui.keyCode.DOWN, false);

should return promise, per documentation, but since 2.31 returns undefined.

I tracked it down to the fact, that in 2.30.2 and earlier, there was one return with:

return res || _getResolvedPromise()

which guaranteed that there's always a promise.

But in 2.31, there's multiple returns without "guard":

return node.setFocus();

.setFocus() returns undefined, but this is now "unguarded", so the client code gets undefined and not promise.

@mar10 mar10 added the bug label Jun 15, 2019
@mar10
Copy link
Owner

mar10 commented Jun 15, 2019

Good catch. This method was refactored to handle the new viewport feature and introduced that regression.

@mar10 mar10 closed this as completed in e8ab014 Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants