Ext-dnd5: bug in function onDropEvent (case 'dragover')

[TimePerformance]

Sorry it is difficult to describe the problem but the bug can cause a lot of issues as the data object is not well initialized.

How to reproduce:

In the demo of the dnd5 extension, it shouldn't be allowed to drop a folder on itself (according to preventVoidMoves = true and the code) but it is allowed.

Analysis:

After searching for hours, it seems that a call to prepareDropEffectCallback(event, data) is missing before the line 833
LAST_HIT_MODE = handleDragOver(event, data);
Without it, data is not well initialized (for instance dropEffect is undefined)
Actually, adding the call to prepareDropEffectCallback seems to solve the problem.

• Fancytree version: v2.32.0
• affected extensions: dnd5

[TimePerformance]

I've jsut created a pull request

[mar10]

Thanks for fixing that. looks like it works!
However, your patch changes 39 files. Seems you made and commited a build?
Can you cleanup a bit, so only one file is affected. You can also add aline to the changelog if you like.
Thanks!