Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[edit] No exception (node null error) for canceling addSibling and addChildren. #984

Closed
Roinoss opened this issue Jan 3, 2020 · 4 comments

Comments

@Roinoss
Copy link

Roinoss commented Jan 3, 2020

Expected and Actual Behavior

Expected: No info in log or cancel action log info in console.
Actual: Error log.

Steps to Reproduce the Problem

Code:
https://wwwendt.de/tech/fancytree/demo/index.html#sample-multi-ext.html
Steps:

  1. Add Child or Sibling to anything in file tree.
  2. Cancel editing new file (esc).
  3. Error in console: TypeError: node is null jquery.fancytree.edit.js:216:4
    3.1 As some base error, with debugLevel: 0 it still shows in console log.

Others:
Also that example uses DEPRECATED version of fancytree.getTree usage.
Fancytree@1 $().fancytree('getTree') is deprecated (see https://wwwendt.de/tech/fancytree/doc/jsdoc/Fancytree_Widget.html

@Roinoss Roinoss changed the title No exception (node null error) for canceling addSibling and addChildren in usage with edit extension. [edit] No exception (node null error) for canceling addSibling and addChildren. Jan 3, 2020
@mar10
Copy link
Owner

mar10 commented Jan 3, 2020

That is fixed now.
However I did not see the deprecation message, this was replace a while ago. Maybe you have an old version cached?

@mar10 mar10 closed this as completed in 2b2b261 Jan 3, 2020
@Roinoss
Copy link
Author

Roinoss commented Jan 3, 2020

Looks like deprecation message is fixed now in example with changed to tree = $.ui.fancytree.getTree(this), from tree = $(this).fancytree("getTree"), in example code, as it is now, but
Type error = null in jquery.fancytree.edit.js:216:4 after adding new sibling or child without sign in its name still is loging in console.

Changelog both in my local site and example site shows 2.34.0 version.
debugLevel: 0 not hiding that error.
(thus that error does not cause any visual problems except showing itself in console)
Different browsers also have that error and clearing cached page files isn't helpful.

@mar10
Copy link
Owner

mar10 commented Jan 3, 2020

The fix is in the current code (will be released with 3.34.1, but I don't have a concrete date)

@Roinoss
Copy link
Author

Roinoss commented Jan 3, 2020

Ok, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants