Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support passing an element as label to the fields and inputs #4813

Closed
djhi opened this issue May 14, 2020 · 1 comment
Closed

Support passing an element as label to the fields and inputs #4813

djhi opened this issue May 14, 2020 · 1 comment
Labels
enhancement

Comments

@djhi
Copy link
Contributor

djhi commented May 14, 2020

Is your feature request related to a problem? Please describe.
When trying to pass an element as the label prop for an input or field, there are multiple warning in the console (one related to translation and another related to PropTypes)

Describe the solution you'd like
<FieldTitle /> should check if label is a valid element before trying to translate it
@djhi djhi mentioned this issue May 25, 2020
Merged
@fzaninotto
Copy link
Member

Fixed by #4852

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fzaninotto @djhi