Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intl Android Support #249

Closed
eunddodi opened this issue Sep 4, 2023 · 4 comments
Closed

Intl Android Support #249

eunddodi opened this issue Sep 4, 2023 · 4 comments

Comments

@eunddodi
Copy link

eunddodi commented Sep 4, 2023

The issue facebook/hermes#23 has been marked as closed, indicating that Hermes now includes support for the Internationalization API (Intl). In light of this update, I would like to inquire about the current status of 'date-fns-tz' on Android in React Native. It appears that the information provided in the "Usage with Android" section of README.md may no longer be accurate or up-to-date.

Could you please confirm whether 'date-fns-tz' is now available and functional on Android in React Native with Hermes? Additionally, if there have been any changes or updates regarding its usage, it would be greatly appreciated if you could provide the latest guidance or documentation for reference.

Thank you for your assistance in clarifying this matter.

@marnusw
Copy link
Owner

marnusw commented Sep 4, 2023

@eunddodi thank you for sharing the update on Intl support in Hermes. As long as the JavaScript Intl API is supported, then date-fns-tz should "just work" in React Native Android apps. This library is pure JS. Any instructions for making it work on Android are purely for getting the JS Intl API working correctly. Please give it a try and if it works now we can update the README.

@Siumauricio
Copy link

Confirmed date-fns-tz is working with zero config in RN Version 0.72.3

@marnusw
Copy link
Owner

marnusw commented Sep 11, 2023

Excellent @Siumauricio, thank you for investigating. I'll leave this open until I've had time to update the docs.

@marnusw
Copy link
Owner

marnusw commented Apr 6, 2024

The documentation is now up to date.

@marnusw marnusw closed this as completed Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants