Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aliases field from /publicRooms #3056

Closed
richvdh opened this issue Mar 10, 2021 · 1 comment · Fixed by #3624
Closed

Remove aliases field from /publicRooms #3056

richvdh opened this issue Mar 10, 2021 · 1 comment · Fixed by #3624
Assignees
Labels
spec-bug Something which is in the spec, but is wrong

Comments

@richvdh
Copy link
Member

richvdh commented Mar 10, 2021

... or at least make a suggestion that servers don't return it

Link to problem area:

https://spec.matrix.org/unstable/client-server-api/#get_matrixclientr0publicrooms

Issue

The spec for /publicRooms suggests that servers should return an aliases field from the /publicRooms. However, MSC2432 changed most of the rest of the spec so that m.room.aliases events are no longer treated specially, and matrix-org/synapse#6970 removed support for this field from Synapse.

Although this endpoint was never called out explicitly in MSC2432, I think that was just an oversight. It might be nice if the situation was at least made clearer in the spec.

Expected behaviour

Remove the field altogether? Or call out that it may not be returned by common server impls, and recommend that servers don't populate it?

@richvdh richvdh added the spec-bug Something which is in the spec, but is wrong label Mar 10, 2021
@turt2live turt2live self-assigned this Jan 5, 2022
@turt2live
Copy link
Member

ah ha, we do have an issue for this. In a different line of investigation we ran across this exact issue. Proposed for removal here: #3624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec-bug Something which is in the spec, but is wrong
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants