Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mod_auth_matrix_user_verification module needs to be fully async #10

Closed
jaywink opened this issue Mar 24, 2021 · 0 comments · Fixed by #11
Closed

mod_auth_matrix_user_verification module needs to be fully async #10

jaywink opened this issue Mar 24, 2021 · 0 comments · Fixed by #11
Labels
bug Something isn't working

Comments

@jaywink
Copy link
Member

jaywink commented Mar 24, 2021

Currently the mod_auth_matrix_user_verification does some network calls to UVS in a synchronous way which blocks prosody for the time these resolve.

Any network calls made by the module need to be fully async so that Prosody is not blocked.

#9 was a quick attempt to resolve but it makes Prosody crash.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@jaywink