Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Update spaces summary to use join rules, not history visibility #10255

Closed
clokep opened this issue Jun 25, 2021 · 2 comments · Fixed by #10298
Closed

Update spaces summary to use join rules, not history visibility #10255

clokep opened this issue Jun 25, 2021 · 2 comments · Fixed by #10298
Assignees
@clokep
Labels
T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@clokep
Copy link
Member

clokep commented Jun 25, 2021

Now that MSC3173 has merged we've updated MSC2946 to mention that join rules, not history visibility, should be used when returning results in the spaces summary.

We need to update the spaces summary to include any rooms that are joinable as opposed to those with world readable history visibility.
@clokep clokep added the T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. label Jun 25, 2021
@clokep clokep self-assigned this Jun 25, 2021
@clokep
Copy link
Member Author

clokep commented Jun 25, 2021

This should mostly involve messing with the SpaceSummaryHandler._is_room_accessible method.

@clokep clokep mentioned this issue Jul 1, 2021
Merged
@clokep
Copy link
Member Author

clokep commented Jul 1, 2021

#10298 should fix this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@clokep clokep

Labels
T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show joinable rooms in the spaces summary. matrix-org/synapse
1 participant
@clokep